Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: [WIP] KUDU-2973 Normalize table names for Ranger ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15018/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15018/2//COMMIT_MSG@7 PS2, Line 7: [WIP] KUDU-2973 Normalize table names for Ranger > Does this commit satisfy KUDU-2973 in full? It's not clear (in part because Updated the description for KUDU-2973 to be more clear. http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/master/catalog_manager.cc@5168 PS2, Line 5168: if (hms::HmsCatalog::IsEnabled() || Will this patch includes database name parsing (based on the table name)? I also not sure why we want to normalize the table name if Ranger integration is enabled. Since we consider table name to be case sensitive with Ranger integration. For case that both Ranger and HMS integration are enabled, we may want to use the non-normalized table name for retrieving Ranger policies as well? -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Jan 2020 07:31:36 +0000 Gerrit-HasComments: Yes
