Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 )
Change subject: schema: use dense_hash_map instead of std::unordered_map ...................................................................... Patch Set 1: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/20180/ : FAILURE This test failure seems legit: I0117 17:21:26.974736 1801 catalog_manager.cc:2397] Servicing AlterTable request from {username='slave'} at 127.0.0.1:43500: table { table_name: "client-testtb" } alter_schema_steps { type: RENAME_COLUMN rename_column { old_name: "int_val" new_name: "" } } modify_external_catalogs: true client-test: /home/jenkins-slave/workspace/kudu-master/2/thirdparty/installed/common/include/sparsehash/internal/densehashtable.h:976: std::pair<iterator, bool> google::dense_hashtable<std::pair<const StringPiece, unsigned long>, StringPiece, GoodFastHash<StringPiece>, google::dense_hash_map<StringPiece, unsigned long, GoodFastHash<StringPiece>, std::equal_to<StringPiece>, STLCountingAllocator<std::pair<const StringPiece, unsigned long>, std::allocator<std::pair<const StringPiece, unsigned long> > > >::SelectKey, google::dense_hash_map<StringPiece, unsigned long, GoodFastHash<StringPiece>, std::equal_to<StringPiece>, STLCountingAllocator<std::pair<const StringPiece, unsigned long>, std::allocator<std::pair<const StringPiece, unsigned long> > > >::SetKey, std::equal_to<StringPiece>, STLCountingAllocator<std::pair<const StringPiece, unsigned long>, std::allocator<std::pair<const StringPiece, unsigned long> > > >::insert_noresize(K &&, Args &&...) [Value = std::pair<const StringPiece, unsigned long>, Key = StringPiece, HashFcn = GoodFastHash<StringPiece>, ExtractKey = google::dense_hash_map<StringPiece, unsigned long, GoodFastHash<StringPiece>, std::equal_to<StringPiece>, STLCountingAllocator<std::pair<const StringPiece, unsigned long>, std::allocator<std::pair<const StringPiece, unsigned long> > > >::SelectKey, SetKey = google::dense_hash_map<StringPiece, unsigned long, GoodFastHash<StringPiece>, std::equal_to<StringPiece>, STLCountingAllocator<std::pair<const StringPiece, unsigned long>, std::allocator<std::pair<const StringPiece, unsigned long> > > >::SetKey, EqualKey = std::equal_to<StringPiece>, Alloc = STLCountingAllocator<std::pair<const StringPiece, unsigned long>, std::allocator<std::pair<const StringPiece, unsigned long> > >, K = const StringPiece &, Args = <const std::pair<const StringPiece, unsigned long> &>]: Assertion `!equals(std::forward<K>(key), key_info.empty_key) && "Inserting the empty key"' failed. -- To view, visit http://gerrit.cloudera.org:8080/15064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 17 Jan 2020 18:14:53 +0000 Gerrit-HasComments: No
