Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 )
Change subject: schema: use dense_hash_map instead of std::unordered_map ...................................................................... Patch Set 3: Code-Review+2 (1 comment) LGTM, maybe Adar has more feedback http://gerrit.cloudera.org:8080/#/c/15064/1/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/15064/1/src/kudu/common/schema.h@503 PS1, Line 503: :move(cols), ids, k > I rejiggered all this stuff in the next revision. Given the dense map is a yup, num_columns() seems to be the best choice here :) -- To view, visit http://gerrit.cloudera.org:8080/15064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 22:04:11 +0000 Gerrit-HasComments: Yes
