Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 )
Change subject: schema: use dense_hash_map instead of std::unordered_map ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15064/4/thirdparty/patches/sparsehash-0002-Add-workaround-for-dense_hashtable-move-constructor-.patch File thirdparty/patches/sparsehash-0002-Add-workaround-for-dense_hashtable-move-constructor-.patch: PS4: > Did you also submit this patch upstream? nope, last time I tried to submit a gcc 4.8 compatibility patch upstream they didn't seem keen on workarounds for gcc 4.8 (https://github.com/sparsehash/sparsehash-c11/pull/19) -- To view, visit http://gerrit.cloudera.org:8080/15064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 22:50:11 +0000 Gerrit-HasComments: Yes
