Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15058 )
Change subject: build: restrict clang version, prefer lld, enable thinlto ...................................................................... Patch Set 3: (3 comments) turns out there's a bug in LLD with weak symbol handling. Added a workaround. http://gerrit.cloudera.org:8080/#/c/15058/3/cmake_modules/KuduLinker.cmake File cmake_modules/KuduLinker.cmake: http://gerrit.cloudera.org:8080/#/c/15058/3/cmake_modules/KuduLinker.cmake@38 PS3, Line 38: # How we handle this situation depends on other factors: : # - If gold is optional, we won't use it. : # - If gold is required and we're using dynamic linking, we'll either: : # - Raise an error in RELEASE builds (we shouldn't release such a product), or : # - Drop tcmalloc in all other builds. > Forgot to mention earlier, but this needs to be updated to reflect the new Done http://gerrit.cloudera.org:8080/#/c/15058/3/cmake_modules/KuduLinker.cmake@61 PS3, Line 61: > Whitespace. Done http://gerrit.cloudera.org:8080/#/c/15058/3/cmake_modules/KuduLinker.cmake@112 PS3, Line 112: # GNU ld version 2.25.1-22.base.el7 > Trailing whitespace. Done -- To view, visit http://gerrit.cloudera.org:8080/15058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0 Gerrit-Change-Number: 15058 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2020 21:15:32 +0000 Gerrit-HasComments: Yes
