Hello Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15058

to look at the new patch set (#4).

Change subject: build: restrict clang version, prefer lld, enable thinlto
......................................................................

build: restrict clang version, prefer lld, enable thinlto

* Restricts clang to at least version 6.0, which gets rid of a couple
  older special cases.

* We now loop through linkers trying to prefer lld where available,
  either using the version provided by the compiler with -fuse-lld or
  explicitly passing the path to the toolchain lld. lld should be faster
  than gold and GNU ld, and also has the advantage of being a known
  quantity within our toolchain.

  This fixes ASAN builds on my Ubuntu 18 machine, where the version of
  gold that ships with the system can't seem to link ASAN executables.

* Switches the LTO build to use ThinLTO, which provides most of the
  performance benefits but at much lower cost.

Change-Id: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0
---
M CMakeLists.txt
A cmake_modules/KuduLinker.cmake
2 files changed, 191 insertions(+), 120 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15058/4
--
To view, visit http://gerrit.cloudera.org:8080/15058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0
Gerrit-Change-Number: 15058
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to