Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15102 )
Change subject: tools: add tool to get the quiescing status of a tablet server ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@379 PS1, Line 379: "Quiescing | Tablet leader count | Active scanner count\n" : "-----------+---------------------+----------------------\n" > Surprised the output isn't well aligned. +1 For better readability, maybe use a different way of defining the pattern for the expected output, something like at https://github.com/apache/kudu/blob/eb7fb1f40dd4c700aae83b21e4a2e4d4cbf4b41c/src/kudu/security/test/mini_kdc.cc#L184-L197 ? -- To view, visit http://gerrit.cloudera.org:8080/15102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I233753cd7daba921506eb1e8e7bf7cdfae3ef0d5 Gerrit-Change-Number: 15102 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2020 19:43:39 +0000 Gerrit-HasComments: Yes
