Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15102 )
Change subject: tools: add tool to get the quiescing status of a tablet server ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@379 PS1, Line 379: ASSERT_STR_CONTAINS(stdout, : " Quiescing | Tablet leader count | Active scanner count\n" > Oh, I thought the alignment issue was with DataTable itself; didn't realize Well, you could use the known upper boundary for the result field width and use 'false' and ' true' to substitute the values. The result count of the scanners is free from the formatting woes like that. Less LoC as the result and a bit easier to read. Anyways, it a nit and it's up to you. http://gerrit.cloudera.org:8080/#/c/15102/2/src/kudu/tserver/tserver_admin.proto File src/kudu/tserver/tserver_admin.proto: http://gerrit.cloudera.org:8080/#/c/15102/2/src/kudu/tserver/tserver_admin.proto@167 PS2, Line 167: This field is returned regardless of whether the server's : // quiescing state was changed nit: I guess 'This field is always populated' would be easier to comprehend. -- To view, visit http://gerrit.cloudera.org:8080/15102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I233753cd7daba921506eb1e8e7bf7cdfae3ef0d5 Gerrit-Change-Number: 15102 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2020 20:32:48 +0000 Gerrit-HasComments: Yes
