Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15102 )
Change subject: tools: add tool to get the quiescing status of a tablet server ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@379 PS1, Line 379: "Quiescing | Tablet leader count | Active scanner count\n" : "-----------+---------------------+----------------------\n" > +1 It's a bit difficult to do that with a data table, since the results affect the spacing. Fixed the alignment though. http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/tserver/tablet_service.cc@1025 PS1, Line 1025: resp->set_is_quiescing(quiesce_tserver); : } else { : resp->set_is_quiescing(server_->quiescing()); : } > Replace with simply unconditional Yeah, I wrote it this way to only do an atomic load once, though I do like that this improves readability. Done http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/tserver/tserver_admin.proto File src/kudu/tserver/tserver_admin.proto: http://gerrit.cloudera.org:8080/#/c/15102/1/src/kudu/tserver/tserver_admin.proto@166 PS1, Line 166: Returns whether the tablet server after having processed the request is : // quiescing > nit: could you make add information on when to expect this field populated? Done -- To view, visit http://gerrit.cloudera.org:8080/15102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I233753cd7daba921506eb1e8e7bf7cdfae3ef0d5 Gerrit-Change-Number: 15102 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2020 20:03:36 +0000 Gerrit-HasComments: Yes
