Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8134
to look at the new patch set (#4).
Change subject: KUDU-2155: disarm failure detector around elections
......................................................................
KUDU-2155: disarm failure detector around elections
This is a more complete fix for KUDU-2149 which disarms the failure detector
completely around a leader election.
There are several changes to make this happen:
1. The FD is changed to use a one-shot timer, which automatically disarms
upon firing.
2. Because all elections are guaranteed to reach DoElectionCallback, that's
where we rearm the FD.
3. We provide a special case for pre-elections where FD rearming is deferred
until after the subsequent real election finishes.
I'm still not convinced this is the cleanest approach, but it seems to work.
Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 66 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/8134/4
--
To view, visit http://gerrit.cloudera.org:8080/8134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97
Gerrit-Change-Number: 8134
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
