Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8134 )
Change subject: KUDU-2155: disarm failure detector around elections ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8134/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8134/3/src/kudu/consensus/raft_consensus.cc@2217 PS3, Line 2217: Status s = raft_pool_token_->SubmitFunc What if ServiceUnavailable is returned not because of the pool shutting down, but because of too many threads already busy running some tasks? What happens with the callback and the leader failure detector in such case? http://gerrit.cloudera.org:8080/#/c/8134/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8134/4/src/kudu/consensus/raft_consensus.cc@675 PS4, Line 675: nit: this string literal is used twice in this scope; maybe create a variable for it? -- To view, visit http://gerrit.cloudera.org:8080/8134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97 Gerrit-Change-Number: 8134 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2020 04:15:00 +0000 Gerrit-HasComments: Yes
