Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8134 )
Change subject: KUDU-2155: disarm failure detector around elections ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/8134/4/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/8134/4/src/kudu/consensus/raft_consensus.h@642 PS4, Line 642: This typically occurs at startup : // and when the local peer steps down as leader. nit: We can be a bit more detailed here, right? We'll try starting the failure detector when we're a follower and we think there's no election going on. As such, maybe also comment that we only do this at the end of an election? http://gerrit.cloudera.org:8080/#/c/8134/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8134/4/src/kudu/consensus/raft_consensus.cc@673 PS4, Line 673: !s.ok() nit: PREDICT_FALSE? same below -- To view, visit http://gerrit.cloudera.org:8080/8134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97 Gerrit-Change-Number: 8134 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2020 02:49:58 +0000 Gerrit-HasComments: Yes
