Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 )
Change subject: [util] remove timeout parameter for cloud::InstanceDetector ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15168/1/src/kudu/util/cloud/instance_detector.cc File src/kudu/util/cloud/instance_detector.cc: http://gerrit.cloudera.org:8080/#/c/15168/1/src/kudu/util/cloud/instance_detector.cc@65 PS1, Line 65: // Add an extra delay in addition to the declared timeout for fetching : // instance metadata. The idea is to have the limit on the time to wait : // in case if instance metadata fetcher could not fulfill its promise to : // return valid result or an error within the init_timeout() interval. > Yeah but is this actually possible? Or a hypothetical concern? It's more a hypothetical concern at this point since we know that CURL works pretty reliably w.r.t. sticking to the specified timeouts modulo various scheduler anomalies. As I understand, the destructor will wait for all threads to join, so there should be no issue with writing into uninitialized memory. -- To view, visit http://gerrit.cloudera.org:8080/15168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f7cac9273e884abda22b9e9a7d37fa3e307c2d4 Gerrit-Change-Number: 15168 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2020 01:54:17 +0000 Gerrit-HasComments: Yes
