Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15168
to look at the new patch set (#2).
Change subject: [util] remove timeout parameter for cloud::InstanceDetector
......................................................................
[util] remove timeout parameter for cloud::InstanceDetector
With this patch, the detector relies solely on the timeouts reported
by metadata fetchers and doesn't set the timeout on the auto-detection
process itself. This change simplifies the semantics of the cloud
instance detection.
In addition, and this patch fixes intermittent failures recently seen
in the following test scenarios when running on non-cloud hosts:
* InstanceDetectorTest.Basic
* BuiltinNtpWithMiniChronydTest.CloudInstanceNtpServer
Change-Id: I6f7cac9273e884abda22b9e9a7d37fa3e307c2d4
---
M src/kudu/clock/ntp-test.cc
M src/kudu/util/cloud/instance_detector-test.cc
M src/kudu/util/cloud/instance_detector.cc
M src/kudu/util/cloud/instance_detector.h
M src/kudu/util/cloud/instance_metadata.cc
M src/kudu/util/cloud/instance_metadata.h
6 files changed, 79 insertions(+), 98 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/15168/2
--
To view, visit http://gerrit.cloudera.org:8080/15168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f7cac9273e884abda22b9e9a7d37fa3e307c2d4
Gerrit-Change-Number: 15168
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <[email protected]>