Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15168 )
Change subject: [util] remove timeout parameter for cloud::InstanceDetector ...................................................................... [util] remove timeout parameter for cloud::InstanceDetector With this patch, the detector relies solely on the timeouts reported by metadata fetchers and doesn't set the timeout on the auto-detection process itself. This change simplifies the semantics of the cloud instance detection. In addition, and this patch fixes intermittent failures recently seen in the following test scenarios when running on non-cloud hosts: * InstanceDetectorTest.Basic * BuiltinNtpWithMiniChronydTest.CloudInstanceNtpServer Change-Id: I6f7cac9273e884abda22b9e9a7d37fa3e307c2d4 Reviewed-on: http://gerrit.cloudera.org:8080/15168 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/clock/ntp-test.cc M src/kudu/util/cloud/instance_detector-test.cc M src/kudu/util/cloud/instance_detector.cc M src/kudu/util/cloud/instance_detector.h M src/kudu/util/cloud/instance_metadata.cc M src/kudu/util/cloud/instance_metadata.h 6 files changed, 79 insertions(+), 98 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6f7cac9273e884abda22b9e9a7d37fa3e307c2d4 Gerrit-Change-Number: 15168 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]>
