Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15136 )
Change subject: KUDU-1438: [java] Upgrade to Netty 4 ...................................................................... Patch Set 6: (3 comments) The test failure looks relevant. http://gerrit.cloudera.org:8080/#/c/15136/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15136/6//COMMIT_MSG@27 PS6, Line 27: deafult default http://gerrit.cloudera.org:8080/#/c/15136/6//COMMIT_MSG@34 PS6, Line 34: negligable negligible http://gerrit.cloudera.org:8080/#/c/15136/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/15136/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@373 PS6, Line 373: // Netty uses 'simple' leak detection by default which carries a small overhead. : // To avoid this overhead in production use, we disable leak detection unless : // a level is explicitly set. You sure we want to do this? Is the overhead measurable? The webpage you linked to suggests that DISABLED isn't recommended (which I presume they mean even for production). -- To view, visit http://gerrit.cloudera.org:8080/15136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic75bd15a982187039ff2e1510af9390d304f7626 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Feb 2020 21:52:56 +0000 Gerrit-HasComments: Yes
