Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15136 )
Change subject: KUDU-1438: [java] Upgrade to Netty 4 ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15136/8/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: http://gerrit.cloudera.org:8080/#/c/15136/8/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java@191 PS8, Line 191: this.bootstrap = bootstrap.clone(); So is this the model in Netty? You manage a single Bootstrap (and its configuration), then clone it for each connection? http://gerrit.cloudera.org:8080/#/c/15136/8/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java@438 PS8, Line 438: ctx.close(); Presumably this is a no-op if ctx.channel().isOpen()? -- To view, visit http://gerrit.cloudera.org:8080/15136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic75bd15a982187039ff2e1510af9390d304f7626 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 Feb 2020 20:24:36 +0000 Gerrit-HasComments: Yes
