Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15136 )
Change subject: KUDU-1438: [java] Upgrade to Netty 4 ...................................................................... KUDU-1438: [java] Upgrade to Netty 4 This patch upgrades from Netty 3 to the latest Netty 4. Below is a list of some of the changes required: - Changed org.jboss.netty imports to io.netty - Adjust shading to relocate io.netty - Removed outdated reflection in Bytes.java - Changed ChannelBuffer to ByteBuffer - Changed OneToOneDecoder to BytesToMessageDecoder - Changed OneToOneEncoder to MessageToByteEncoder - Changed DecoderEmbedder to EmbeddedChannel - Changed Negotiator and Connection to extend SimpleChannelInboundHandler instead of SimpleChannelUpstreamHandler - Worked around non-sharable SslHandler - Migrated from NioClientSocketChannelFactory to Netty Boostrap - Removed boss threads and deprecated setter methods in the AsyncKuduClient - Removed ShutdownThread in AsyncKuduClient - Updated Negotiator tests to unwrap SSL messages - Added build flag to run tests with paranoid level leak detection - Suppressed errorprone FutureReturnValueIgnored warnings I used YCSB to performance test this change and ensure there isn’t a large performance regression. On an m4.2xlarge instance I ran a test of 5 iterations of workload a, b, and c using 1M records and 1M operations. The difference between runs was negligible (< 1%) and within test variance. Change-Id: Ic75bd15a982187039ff2e1510af9390d304f7626 Reviewed-on: http://gerrit.cloudera.org:8080/15136 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M java/gradle/dependencies.gradle M java/gradle/shadow.gradle M java/gradle/tests.gradle M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableStatisticsRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletServersRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletsRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/RpcOutboundMessage.java M java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java 39 files changed, 504 insertions(+), 488 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic75bd15a982187039ff2e1510af9390d304f7626 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 9 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
