Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 )
Change subject: [clock] introduce time source auto selection ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/15161/8/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15161/8/src/kudu/clock/hybrid_clock.cc@433 PS8, Line 433: if (clock::BuiltInNtp::auto_configuration_enabled()) { > I think current code guarantees that only one InstanceDetector is used: the Ah, and the importance of the '--time_source=builtin --builtin_ntp_enable_auto_config=true' case is that it gives you guarantee of using the built-in NTP client, regardless of the environment you run Kudu at. It either uses the dedicated NTP servers if the environment provides that or uses the specified NTP servers (or the default list). I thought that would be the way of making the built-in NTP client the default time source with the ability to use the dedicated servers in case of cloud providers. Or we don't need the assurance of using the built-in NTP client regardless of the environment? -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2020 07:34:20 +0000 Gerrit-HasComments: Yes
