Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 )
Change subject: [clock] introduce time source auto selection ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@416 PS6, Line 416: result_builtin_ntp_servers.emplace_back(ntp_server, : clock::kStandardNtpPort); > After taking a closer look, I think passing around the auto-detected server I don't feel strongly about this. What I do care more about is: 1. That there's just one InstanceDetector. We may add more auto-configuration for cloud providers in the future, and it'll be annoying to consider multiple InstanceDetectors, each in a different module at a different place in the overall server module hierarchy, not to mention guarantee that we only ever run one InstanceDetector in a given server startup. 2. That we minimize the number of control knobs. Meaning, we should consider all the possible use cases, eliminate ones we don't think are important, and end up with a small number of knobs for users to consider. -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2020 01:19:41 +0000 Gerrit-HasComments: Yes
