Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 )
Change subject: [clock] introduce time source auto selection ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@416 PS6, Line 416: result_builtin_ntp_servers.emplace_back(ntp_server, : clock::kStandardNtpPort); > Agreed with the global variable sentiment, but worth pointing out that ther This sounds reasonable. I'll set the default value for the glfag then. Thanks. http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@428 PS6, Line 428: if (result_time_source == TimeSource::UNKNOWN) { : // The fallback to TimeSource::SYSTEM_UNSYNC is possible only when : // it's explicitly allowed by --time_source_system_unsync_allowed flag. : if (!FLAGS_time_source_system_unsync_allowed) { : return Status::InvalidArgument( : "no viable time source to auto-select: in a test environment " : "consider setting --time_source_system_unsync_allowed"); : } : result_time_source = TimeSource::SYSTEM_UNSYNC; > I guess what you want is to be able to tag a particular gflag _value_ as un Indeed, the need is to mark a particular gflag value as unsafe. I think using the group validator for that purpose is a great idea. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2020 23:11:15 +0000 Gerrit-HasComments: Yes
