Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15210 )
Change subject: [java] KUDU-2971: add an outbound queue ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/15210/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15210/2//COMMIT_MSG@11 PS2, Line 11: So that in case stdout fills up, the message parser tasks : can continue processing the requests without blocking. Is this something we can test? http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java: http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java@26 PS2, Line 26: message messages http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java@28 PS2, Line 28: public class QueueUtil { @InterfaceAudience.Private http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java: http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@46 PS2, Line 46: the don't need 'the' http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@49 PS2, Line 49: puts put http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@51 PS2, Line 51: retrieve retrieves http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@52 PS2, Line 52: write writes http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@52 PS2, Line 52: the don't need 'the' -- To view, visit http://gerrit.cloudera.org:8080/15210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0793ad35af5342bb9af4f2f0eaed4090f78ef3c6 Gerrit-Change-Number: 15210 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 Feb 2020 17:35:16 +0000 Gerrit-HasComments: Yes
