Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15210 )
Change subject: [java] KUDU-2971: add an outbound queue ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15210/3/java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java File java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java: http://gerrit.cloudera.org:8080/#/c/15210/3/java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java@185 PS3, Line 185: write writing http://gerrit.cloudera.org:8080/#/c/15210/3/java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java@197 PS3, Line 197: final String[] args = {""}; This could be moved into the run() block itself, right? Maybe do that elsewhere too? http://gerrit.cloudera.org:8080/#/c/15210/3/java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java@213 PS3, Line 213: Assert.assertTrue(outboundQueue.size() == 1); assertEquals instead? -- To view, visit http://gerrit.cloudera.org:8080/15210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0793ad35af5342bb9af4f2f0eaed4090f78ef3c6 Gerrit-Change-Number: 15210 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Feb 2020 05:32:31 +0000 Gerrit-HasComments: Yes
