Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15210 )

Change subject: [java] KUDU-2971: add an outbound queue
......................................................................


Patch Set 3:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/15210/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15210/2//COMMIT_MSG@11
PS2, Line 11: So that in case stdout fills up, the message parser tasks
            : can continue processing the requests without blocking.
> Is this something we can test?
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java
File 
java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java:

http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java@26
PS2, Line 26:
> messages
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/QueueUtil.java@28
PS2, Line 28:  */
> @InterfaceAudience.Private
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java
File 
java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java:

http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@46
PS2, Line 46: sta
> don't need 'the'
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@49
PS2, Line 49: put
> put
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@51
PS2, Line 51: retrieve
> retrieves
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@52
PS2, Line 52: write
> writes
Done


http://gerrit.cloudera.org:8080/#/c/15210/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@52
PS2, Line 52:  st
> don't need 'the'
Done



--
To view, visit http://gerrit.cloudera.org:8080/15210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0793ad35af5342bb9af4f2f0eaed4090f78ef3c6
Gerrit-Change-Number: 15210
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Feb 2020 04:51:38 +0000
Gerrit-HasComments: Yes

Reply via email to