Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15221 )
Change subject: rpc: allow a sidecar to append multiple slices ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/rpc/inbound_call.h File src/kudu/rpc/inbound_call.h: http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/rpc/inbound_call.h@136 PS2, Line 136: // Returns the number of slices in the serialized response. Update. http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/rpc/rpc_sidecar.h File src/kudu/rpc/rpc_sidecar.h: http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/rpc/rpc_sidecar.h@43 PS2, Line 43: Data is copied from the Slice returned from : // AsSlice() to the socket that is responding to the original RPC Should be updated since AsSlice() no longer exists. http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/util/faststring.h File src/kudu/util/faststring.h: http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/util/faststring.h@60 PS2, Line 60: faststring(faststring&& other) noexcept Might want to add a move assignment operator too; classes with one but not the other can feel weird to work with. http://gerrit.cloudera.org:8080/#/c/15221/2/src/kudu/util/faststring.h@241 PS2, Line 241: void CheckInvariants() { Add short doc? -- To view, visit http://gerrit.cloudera.org:8080/15221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05b4d5e5243735db943e315268d837f662891b1a Gerrit-Change-Number: 15221 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Feb 2020 06:00:24 +0000 Gerrit-HasComments: Yes
