Hello Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15221

to review the following change.


Change subject: rpc: allow a sidecar to append multiple slices
......................................................................

rpc: allow a sidecar to append multiple slices

This adds support for sidecars to use vectors of Slices instead of a
single Slice each. This makes certain code paths a little simpler in the
scanner: we no longer need to worry about appending rowblocks to
existing data buffers. Instead, we just make a new buffer for each batch
to be returned.

Change-Id: I05b4d5e5243735db943e315268d837f662891b1a
---
M src/kudu/common/wire_protocol.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc_controller.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/transfer.cc
M src/kudu/rpc/transfer.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.h
15 files changed, 166 insertions(+), 95 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/15221/1
--
To view, visit http://gerrit.cloudera.org:8080/15221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05b4d5e5243735db943e315268d837f662891b1a
Gerrit-Change-Number: 15221
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>

Reply via email to