Hello Andrew Wong, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15221
to look at the new patch set (#4).
Change subject: rpc: allow a sidecar to append multiple slices
......................................................................
rpc: allow a sidecar to append multiple slices
This adds support for sidecars to use vectors of Slices instead of a
single Slice each. Currently, this isn't used. However, a later patch
will make use of this to support returning scan batches in a columnar
layout. The row-wise layout could also make use of this to improve
allocator efficiency -- a TODO is added for that.
Note: this changes the Transfer code to use a
boost::container::small_vector instead of a hard-coded std::array with
10 elements. This should have the same "embedded in the object"
performance for responses with a small number of slices, while allowing
an unlimited number of slices when needed.
Change-Id: I05b4d5e5243735db943e315268d837f662891b1a
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc_controller.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/transfer.cc
M src/kudu/rpc/transfer.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.h
14 files changed, 203 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/15221/4
--
To view, visit http://gerrit.cloudera.org:8080/15221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05b4d5e5243735db943e315268d837f662891b1a
Gerrit-Change-Number: 15221
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
