Hello Alexey Serbin, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15245
to review the following change.
Change subject: faststring-test: squelch unknown pragmas warning when building
with gcc
......................................................................
faststring-test: squelch unknown pragmas warning when building with gcc
When building faststring-test with gcc, we see these warnings:
../../src/kudu/util/faststring-test.cc:171:0: warning: ignoring #pragma clang
diagnostic [-Wunknown-pragmas]
#pragma clang diagnostic push
../../src/kudu/util/faststring-test.cc:172:0: warning: ignoring #pragma clang
diagnostic [-Wunknown-pragmas]
#pragma clang diagnostic ignored "-Wself-move"
../../src/kudu/util/faststring-test.cc:174:0: warning: ignoring #pragma clang
diagnostic [-Wunknown-pragmas]
#pragma clang diagnostic pop
It doesn't appear to be possible to squelch these via additional pragmas, so
we instead do it in CMake.
Change-Id: Ifa3c1ad13999b64ecfffcab4eb058c2da0c664a7
---
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15245/1
--
To view, visit http://gerrit.cloudera.org:8080/15245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa3c1ad13999b64ecfffcab4eb058c2da0c664a7
Gerrit-Change-Number: 15245
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
