Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15245 )
Change subject: faststring-test: squelch unknown pragmas warning when building with gcc ...................................................................... faststring-test: squelch unknown pragmas warning when building with gcc When building faststring-test with gcc, we see these warnings: ../../src/kudu/util/faststring-test.cc:171:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] #pragma clang diagnostic push ../../src/kudu/util/faststring-test.cc:172:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] #pragma clang diagnostic ignored "-Wself-move" ../../src/kudu/util/faststring-test.cc:174:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] #pragma clang diagnostic pop It doesn't appear to be possible to squelch these via additional pragmas, so we instead do it in CMake. Change-Id: Ifa3c1ad13999b64ecfffcab4eb058c2da0c664a7 Reviewed-on: http://gerrit.cloudera.org:8080/15245 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/CMakeLists.txt M src/kudu/util/faststring-test.cc 2 files changed, 21 insertions(+), 4 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifa3c1ad13999b64ecfffcab4eb058c2da0c664a7 Gerrit-Change-Number: 15245 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]>
