Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15245 )
Change subject: faststring-test: squelch unknown pragmas warning when building with gcc ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15245/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15245/2//COMMIT_MSG@20 PS2, Line 20: additional pragmas Just curious: would using #pragma GCC diagnostic push instead be feasible, so both GCC and clang can recognize the pragma? Or the issue is with "-Wself-move" itself? -- To view, visit http://gerrit.cloudera.org:8080/15245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3c1ad13999b64ecfffcab4eb058c2da0c664a7 Gerrit-Change-Number: 15245 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2020 18:53:15 +0000 Gerrit-HasComments: Yes
