Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15277 )
Change subject: mvcc: remove "safe time" terminology ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.h@194 PS1, Line 194: 'ts' Should this be 'timestamp'? Below too. http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.h@379 PS1, Line 379: i.e. a timestamp below which all transactions are either : // committed or in-flight. I didn't really understand this bit in the old comment too: isn't any transaction, by its very nature, either committed or in-flight? If we're being pedantic I guess there's a third state (aborted) but that doesn't seem relevant to this particular explanation. http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.cc@199 PS1, Line 199: 'ts' 'timestamp' -- To view, visit http://gerrit.cloudera.org:8080/15277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I990478e20039a6ea541c1aa32a2a865f8e017b83 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 23 Feb 2020 22:21:38 +0000 Gerrit-HasComments: Yes
