Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15277 )
Change subject: mvcc: remove "safe time" terminology ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.h@194 PS1, Line 194: 'tim > Should this be 'timestamp'? Below too. Done http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.h@379 PS1, Line 379: timestamp at and below which no new transactions can be : // initialized. > I didn't really understand this bit in the old comment too: isn't any trans Yeah that's fair. I think it was trying to say that any transaction below this timestamp must already have been in-flight or committed. I'll remove it since it doesn't add much, I don't think. http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/15277/1/src/kudu/tablet/mvcc.cc@199 PS1, Line 199: 'tim > 'timestamp' Done -- To view, visit http://gerrit.cloudera.org:8080/15277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I990478e20039a6ea541c1aa32a2a865f8e017b83 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 23 Feb 2020 22:45:46 +0000 Gerrit-HasComments: Yes
