Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15277
to look at the new patch set (#2).
Change subject: mvcc: remove "safe time" terminology
......................................................................
mvcc: remove "safe time" terminology
The MvccManager maintains an exclusive lower bound on the timestamps
allowed for assignment for new transactions. It refers to this as the
"safe time".
MVCC's usage of "safe time" is confusing because it is easily conflated
with the very similar "safe time" in the context of consensus: the
timestamp before which the leader promises not to assign a timestamp for
a new write. This is a distributed property of a tablet, managed by the
leader's consensus::TimeManager, whereas MVCC safe time is managed by
each replica.
This replaces MVCC 'safe_time_' and associated methods with the more
literal 'new_txn_timestamp_exc_lower_bound_', in hopes of making it
clearer 1) what "safe time" is by reducing the number of versions of the
term, and 2) how MVCC's "safe time" (now referred to as the "new
transaction timestamp lower bound") is used.
There are no functional changes in this patch.
Change-Id: I990478e20039a6ea541c1aa32a2a865f8e017b83
---
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/tablet_service.cc
11 files changed, 141 insertions(+), 120 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/15277/2
--
To view, visit http://gerrit.cloudera.org:8080/15277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I990478e20039a6ea541c1aa32a2a865f8e017b83
Gerrit-Change-Number: 15277
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
