Hello Alexey Serbin, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15323
to review the following change.
Change subject: ksck: display quiecing-related info
......................................................................
ksck: display quiecing-related info
This patch adds quiescing-related info to ksck's "Tablet Server Summary"
section. Specifically, it displays the quiescing state, the number of
tablet leaders, and the number of active scanners[1].
If none of the tablet servers are quiescing, the quiescing state column
is omitted. If none of the tablet servers support the quiescing RPC, all
related columns are omitted.
I manually tested against a cluster that fully didn't support quiescing,
as well as one that partially supports quiescing[2].
[1] Sample output:
Tablet Server Summary
UUID | Address | Status |
Location | Quiescing | Tablet Leaders | Active Scanners
----------------------------------+--------------------------------+---------+----------+-----------+----------------+-----------------
1e8c8c55d0e24110b29caaecdae491ca | ve1318.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 2 | 0
36e8894c4e6d48c690f64ade8b5fe52d | ve1320.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 7 | 0
629bbaecfead49f18247d7963cfa98af | ve1319.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 0 | 0
9dfdd5aac2814353bd50cefca2d77403 | ve1321.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 8 | 0
9fe2954950ea4f4eaecc4ef97c6eb44a | ve1317.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 6 | 0
a5dd443f61464c34aca585a905e87926 | ve1322.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 7 | 0
dffda2ef2d33481993d29009f3f87420 | ve1323.halxg.cloudera.com:7050 | HEALTHY |
/default | true | 6 | 0
e6c9b1df642a4cf69c47f36480dd4723 | ve1316.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 6 | 0
efc1275241604b0aa886494f8da9e00b | ve1324.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 7 | 0
[2] Output of partial support for quiescing across the cluster yields "partial"
results; not the prettiest, but it's also not a scenario we expect often:
I0228 18:36:40.200479 383527 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server 629bbaecfead49f18247d7963cfa98af
(ve1319.halxg.cloudera.com:7050): Remote error: unsupported feature flags
I0228 18:36:40.200585 383525 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server 1e8c8c55d0e24110b29caaecdae491ca
(ve1318.halxg.cloudera.com:7050): Remote error: unsupported feature flags
I0228 18:36:40.201057 383526 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server 36e8894c4e6d48c690f64ade8b5fe52d
(ve1320.halxg.cloudera.com:7050): Remote error: unsupported feature flags
I0228 18:36:40.202527 383528 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server 9dfdd5aac2814353bd50cefca2d77403
(ve1321.halxg.cloudera.com:7050): Remote error: unsupported feature flags
I0228 18:36:40.202736 383530 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server a5dd443f61464c34aca585a905e87926
(ve1322.halxg.cloudera.com:7050): Remote error: unsupported feature flags
I0228 18:36:40.202940 383532 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server dffda2ef2d33481993d29009f3f87420
(ve1323.halxg.cloudera.com:7050): Remote error: unsupported feature flags
I0228 18:36:40.203280 383536 ksck_remote.cc:290] Couldn't fetch quiescing info
from tablet server efc1275241604b0aa886494f8da9e00b
(ve1324.halxg.cloudera.com:7050): Remote error: unsupported feature flags
...
Tablet Server Summary
UUID | Address | Status |
Location | Quiescing | Tablet Leaders | Active Scanners
----------------------------------+--------------------------------+---------+----------+-----------+----------------+-----------------
1e8c8c55d0e24110b29caaecdae491ca | ve1318.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
36e8894c4e6d48c690f64ade8b5fe52d | ve1320.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
629bbaecfead49f18247d7963cfa98af | ve1319.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
9dfdd5aac2814353bd50cefca2d77403 | ve1321.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
9fe2954950ea4f4eaecc4ef97c6eb44a | ve1317.halxg.cloudera.com:7050 | HEALTHY |
/default | true | 5 | 0
a5dd443f61464c34aca585a905e87926 | ve1322.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
dffda2ef2d33481993d29009f3f87420 | ve1323.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
e6c9b1df642a4cf69c47f36480dd4723 | ve1316.halxg.cloudera.com:7050 | HEALTHY |
/default | false | 6 | 0
efc1275241604b0aa886494f8da9e00b | ve1324.halxg.cloudera.com:7050 | HEALTHY |
/default | n/a | n/a | n/a
Change-Id: Ibdc650eb3ee30e8993330f2cbd389076ea2bad49
---
M src/kudu/integration-tests/tablet_server_quiescing-itest.cc
M src/kudu/rebalance/cluster_status.h
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/tserver.proto
12 files changed, 147 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/15323/1
--
To view, visit http://gerrit.cloudera.org:8080/15323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdc650eb3ee30e8993330f2cbd389076ea2bad49
Gerrit-Change-Number: 15323
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
