Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15323 )
Change subject: ksck: display quiecing-related info ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck.h@401 PS2, Line 401: std::atomic<uint64_t> timestamp_; Nit: separate from the above with an empty line, so it's clear the comment only applies to quiescing_info_ and not the rest? http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck_remote.cc@290 PS2, Line 290: INFO Not WARNING? -- To view, visit http://gerrit.cloudera.org:8080/15323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdc650eb3ee30e8993330f2cbd389076ea2bad49 Gerrit-Change-Number: 15323 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Mar 2020 06:29:19 +0000 Gerrit-HasComments: Yes
