Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15323 )
Change subject: ksck: display quiecing-related info ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15323/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15323/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@433 PS1, Line 433: ; > I think there is some value in seeing number of leader replicas and number Yeah, I'm taking a "show it if it's important to know about" approach, and if we're not quiescing at all, it's not important to know about. It is somewhat that this is a note on quiescing servers because that's all we need for the sake of quiescing. But leaders/scanners itself seems useful to know about, regardless of quiescing status. I chatted with Grant a bit and he agrees that showing this stuff by default seems desirable, albeit at the cost of making ksck even bulkier. http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck.h@401 PS2, Line 401: > Nit: separate from the above with an empty line, so it's clear the comment Done http://gerrit.cloudera.org:8080/#/c/15323/1/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/15323/1/src/kudu/tools/ksck_remote.cc@81 PS1, Line 81: true > Yep, that makes sense to me. One question: once quiescing status is observ They may, or if they know that a specific set of servers is being quiesced, they may want to periodically check the status of that as leaders and scanners dwindle, but they may not want to run ksck, since that'd return info on the entire cluster. http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/15323/2/src/kudu/tools/ksck_remote.cc@290 PS2, Line 290: WARN > Not WARNING? Done -- To view, visit http://gerrit.cloudera.org:8080/15323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdc650eb3ee30e8993330f2cbd389076ea2bad49 Gerrit-Change-Number: 15323 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Mar 2020 21:15:13 +0000 Gerrit-HasComments: Yes
