Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar ...................................................................... Patch Set 2: (1 comment) It seems all tests which use hms-plugin jar failed with this patch. http://gerrit.cloudera.org:8080/#/c/15360/2/src/kudu/hms/CMakeLists.txt File src/kudu/hms/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15360/2/src/kudu/hms/CMakeLists.txt@73 PS2, Line 73: EXTRA_GRADLE_FLAGS Why not to add --quiet flag here as well? Doing so will make it clear that all gradle flags can be overridden with EXTRA_GRADLE_FLAGS environment variable, if necessary. -- To view, visit http://gerrit.cloudera.org:8080/15360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257 Gerrit-Change-Number: 15360 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Mar 2020 17:24:59 +0000 Gerrit-HasComments: Yes
