Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Just some nits. http://gerrit.cloudera.org:8080/#/c/15360/3/build-support/run_dist_test.py File build-support/run_dist_test.py: http://gerrit.cloudera.org:8080/#/c/15360/3/build-support/run_dist_test.py@164 PS3, Line 164: glob.glob(os.path.join(ROOT, : "java/kudu-hive/build/libs/kudu-hive*"))[0], : os.path.join(bin_path, "hms-plugin.jar")) : os.symlink( : glob.glob(os.path.join(ROOT, : "java/kudu-subprocess/build/libs/kudu-subprocess*"))[0], : os.path.join(bin_path, "kudu-subprocess.jar")) nit: spacing is inconsistent between these http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt File src/kudu/hms/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt@68 PS3, Line 68: Add nit: Adds http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt@77 PS3, Line 77: nit: spacing? -- To view, visit http://gerrit.cloudera.org:8080/15360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257 Gerrit-Change-Number: 15360 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Mar 2020 22:19:15 +0000 Gerrit-HasComments: Yes
