Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar ...................................................................... Patch Set 2: We can leave this if it's preferred. I am not strongly opinionated about it. As I see it, this is a simplification given we have 1 build tool to build Java instead of 2 (Gradle and cmake/make). A downside to the current add_jars approach is that the dependencies used in the Gradle build and tests may be different than those in the c++ test. Using the Gradle build helps verify the published Gradle jar does in fact work. Given these jars are only needed for tests, we should also guard these sections with the `NO_TESTS` flag. I will add that. If speed is a concern on jenkins, I can move the Java build above the c++ build and it should look instant in the c++ build given Gradle will already be primed with all the deps and skip all tasks. If it's a concern for local builds, it should only be slower the first time. And hopefully not much. -- To view, visit http://gerrit.cloudera.org:8080/15360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257 Gerrit-Change-Number: 15360 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Mar 2020 17:40:41 +0000 Gerrit-HasComments: No
