Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15366
Change subject: [wip] subprocess: report metrics even when calls fail ...................................................................... [wip] subprocess: report metrics even when calls fail This moves metric reporting for metrics returned by the subprocess into the SubprocessServer so they are still reported in the event that the call fails. To do this, I moved the SubprocessMetrics into the SubprocessServer, which means that these metrics are now required by the server. As such, I moved the declarations of Echo metrics out of subprocess_proxy-test so they could be reused by other tests. This should prove more useful, particularly given the fact that failed calls warrant a deeper look at these metrics. wip: rebase on https://gerrit.cloudera.org/c/15206/ Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9 --- M src/kudu/subprocess/CMakeLists.txt A src/kudu/subprocess/echo_subprocess.cc A src/kudu/subprocess/echo_subprocess.h M src/kudu/subprocess/server.cc M src/kudu/subprocess/server.h M src/kudu/subprocess/subprocess_proxy-test.cc M src/kudu/subprocess/subprocess_proxy.h M src/kudu/subprocess/subprocess_server-test.cc 8 files changed, 190 insertions(+), 89 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/15366/1 -- To view, visit http://gerrit.cloudera.org:8080/15366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9 Gerrit-Change-Number: 15366 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
