Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15366
to look at the new patch set (#2).
Change subject: subprocess: report metrics even when calls fail
......................................................................
subprocess: report metrics even when calls fail
This moves metric reporting for metrics returned by the subprocess into
the SubprocessServer so they are still reported in the event that the
call fails.
To do this, I moved the SubprocessMetrics into the SubprocessServer,
which means that these metrics are now required by the server. As such,
I moved the declarations of Echo metrics out of subprocess_proxy-test so
they could be reused by other tests.
This should prove more useful, particularly given the fact that failed
calls warrant a deeper look at these metrics.
Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/subprocess/CMakeLists.txt
A src/kudu/subprocess/echo_subprocess.cc
A src/kudu/subprocess/echo_subprocess.h
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/subprocess/subprocess_proxy.h
M src/kudu/subprocess/subprocess_server-test.cc
9 files changed, 200 insertions(+), 91 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/15366/2
--
To view, visit http://gerrit.cloudera.org:8080/15366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9
Gerrit-Change-Number: 15366
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
