Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h File src/kudu/subprocess/server.h: http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h@57 PS1, Line 57: struct SimpleTimer { : SimpleTimer() { : start_time = MonoTime::Now(); : } : MonoTime start_time; : MonoDelta elapsed() const { : return MonoTime::Now() - start_time; : } : }; kudu::StopWatch wasn't simple enough? http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc@307 PS1, Line 307: ; extra semi-colon. -- To view, visit http://gerrit.cloudera.org:8080/15367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179 Gerrit-Change-Number: 15367 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Mar 2020 05:50:19 +0000 Gerrit-HasComments: Yes
