Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics ...................................................................... Patch Set 3: Verified+1 (1 comment) Unrelated flake: security-itest http://gerrit.cloudera.org:8080/#/c/15367/3/src/kudu/subprocess/echo_subprocess.cc File src/kudu/subprocess/echo_subprocess.cc: http://gerrit.cloudera.org:8080/#/c/15367/3/src/kudu/subprocess/echo_subprocess.cc@53 PS3, Line 53: METRIC_DEFINE_histogram(server, echo_server_outbound_queue_time_ms, : "Echo server outbound queue time (ms)", : kudu::MetricUnit::kMilliseconds, : "Duration of time in ms spent in the Echo server's outbound request queue", : kudu::MetricLevel::kInfo, : 60000LU, 1); : METRIC_DEFINE_histogram(server, echo_server_inbound_queue_time_ms, : "Echo server inbound queue time (ms)", : kudu::MetricUnit::kMilliseconds, : "Duration of time in ms spent in the Echo server's inbound response queue", : kudu::MetricLevel::kInfo, : 60000LU, 1); > Wondering why don't have inbound/outbound queue length metrics on the serve Yeah, I wasn't sure between showing the length vs showing the size in bytes. I'm happy to include either at some point, but they're not currently available in BlockingQueue, so it's probably worth separating that out into its own patch if we do want one of those metrics. -- To view, visit http://gerrit.cloudera.org:8080/15367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179 Gerrit-Change-Number: 15367 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Mar 2020 22:13:35 +0000 Gerrit-HasComments: Yes
