Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 )
Change subject: subprocess: add server-side metrics ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h File src/kudu/subprocess/server.h: http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.h@57 PS1, Line 57: struct SimpleTimer { : SimpleTimer() { : start_time = MonoTime::Now(); : } : MonoTime start_time; : MonoDelta elapsed() const { : return MonoTime::Now() - start_time; : } : }; > kudu::StopWatch wasn't simple enough? Nah, and a bunch of it would go to waste unless I expose more metrics. From util/stopwatch.h // The implementation relies on several syscalls, so should not be used for // hot paths, but is useful for timing anything on the granularity of seconds // or more. http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/server.cc@307 PS1, Line 307: > extra semi-colon. Done http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/subprocess_proxy-test.cc File src/kudu/subprocess/subprocess_proxy-test.cc: http://gerrit.cloudera.org:8080/#/c/15367/1/src/kudu/subprocess/subprocess_proxy-test.cc@92 PS1, Line 92: #define GET_HIST(metric_entity, metric_name) \ > warning: macro argument should be enclosed in parentheses [bugprone-macro-p Done -- To view, visit http://gerrit.cloudera.org:8080/15367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51294741ff82bd47e64ceaba18a6d04ae0144179 Gerrit-Change-Number: 15367 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Mar 2020 06:00:41 +0000 Gerrit-HasComments: Yes
