ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 )
Change subject: KUDU-3063: Set a ratio as multiplication factor for memkind_malloc_usable_size ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@76 PS1, Line 76: 1.2 > Thank you for the information. Hopefully, 0.7 (or 10/7 with multiplying me Yes, that's the result reflected by the micro driver. I still keep 1.25 (0.8) as default value. http://gerrit.cloudera.org:8080/#/c/15313/3/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/3/src/kudu/util/nvm_cache.cc@714 PS3, Line 714: : template<> : Cache* NewCache<Cache::EvictionPolicy::LRU, : > I think it's safer to prohibit setting ratio less than 1 at all (with new s Thanks for your advice. Change it to a flag validator. -- To view, visit http://gerrit.cloudera.org:8080/15313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceb1931f5addbf76774854ca1613b6a085b577e3 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 4 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 04:18:25 +0000 Gerrit-HasComments: Yes
