Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 )
Change subject: KUDU-3063: Set a ratio as multiplication factor for memkind_malloc_usable_size ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15313/6/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/6/src/kudu/util/nvm_cache.cc@84 PS6, Line 84: static bool ValidateNVMCacheUsageRatio(const char* flagname, double value) { Should use 2 char indentation here. http://gerrit.cloudera.org:8080/#/c/15313/6/src/kudu/util/nvm_cache.cc@92 PS6, Line 92: the an -- To view, visit http://gerrit.cloudera.org:8080/15313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceb1931f5addbf76774854ca1613b6a085b577e3 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 6 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2020 00:45:31 +0000 Gerrit-HasComments: Yes
