Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 )
Change subject: KUDU-3063: Set a ratio as multiplication factor for memkind_malloc_usable_size ...................................................................... Patch Set 4: (6 comments) Looks good, just a few nits. http://gerrit.cloudera.org:8080/#/c/15313/3/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/3/src/kudu/util/nvm_cache.cc@714 PS3, Line 714: : template<> : Cache* NewCache<Cache::EvictionPolicy::LRU, : > Thanks for your advice. Change it to a flag validator. Thank you for addressing this! http://gerrit.cloudera.org:8080/#/c/15313/4/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/4/src/kudu/util/nvm_cache.cc@89 PS4, Line 89: greater than nit: greater than or equal to http://gerrit.cloudera.org:8080/#/c/15313/4/src/kudu/util/nvm_cache.cc@95 PS4, Line 95: fragmemtation fragmentation http://gerrit.cloudera.org:8080/#/c/15313/4/src/kudu/util/nvm_cache.cc@95 PS4, Line 95: inproper improper http://gerrit.cloudera.org:8080/#/c/15313/4/src/kudu/util/nvm_cache.cc@96 PS4, Line 96: faliures failures http://gerrit.cloudera.org:8080/#/c/15313/4/src/kudu/util/nvm_cache.cc@96 PS4, Line 96: and spaces can not be " : "released nit: maybe rephrase for clarity as while capacity-based evictions are not triggered -- To view, visit http://gerrit.cloudera.org:8080/15313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceb1931f5addbf76774854ca1613b6a085b577e3 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 4 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 19:37:01 +0000 Gerrit-HasComments: Yes
