Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15409 )

Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15409/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/15409/2/build-support/jenkins/build-and-test.sh@280
PS2, Line 280: JAVA8_HOME
What if JAVA8_HOME is not defined at all (e.g., the build machine has only 
JDK11)?  Maybe, add a check for non-empty value and bail if the check failed?



--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 18:53:25 +0000
Gerrit-HasComments: Yes

Reply via email to