Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh@366 PS4, Line 366: pushd $SOURCE_ROOT/java : if ! ./gradlew $EXTRA_GRADLE_FLAGS clean check -x test $EXTRA_GRADLE_TEST_FLAGS; then : LINT_RESULT=1 : LINT_FAILURES="$LINT_FAILURES"$'Java Gradle check failed\n' : fi : popd > Should this also respect BUILD_JAVA? Why or why not? Good question. Do you know where or how that flag is used today? On one hand you could ignore it given we don't want "bad code" to be allowed. On the other you could respect it if users intend it to mean no-java at all. However, no java at all doesn't really exist anymore given the hms plugin and subprocess are both Java that is built in the C++ build. I think it's that last reason that makes me think this should not respect BUILD_JAVA. to ensure bad code isn't making its way into the C++ build too. -- To view, visit http://gerrit.cloudera.org:8080/15409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525 Gerrit-Change-Number: 15409 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Mar 2020 20:20:57 +0000 Gerrit-HasComments: Yes
