Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh@366 PS4, Line 366: pushd $SOURCE_ROOT/java : if ! ./gradlew $EXTRA_GRADLE_FLAGS clean check -x test $EXTRA_GRADLE_TEST_FLAGS; then : LINT_RESULT=1 : LINT_FAILURES="$LINT_FAILURES"$'Java Gradle check failed\n' : fi : popd > Good question. Do you know where or how that flag is used today? Yeah, BUILD_JAVA is definitely from before the HMS plugin landed, and hasn't been reevaluated since then. We could continue to honor it, but we'd need to plumb it into cmake and have cmake exclude HMS/subprocess building and testing if set. Or we could go the other direction and strip it out completely. Or change it into more of a "TEST_JAVA" thing. I'd be inclined to do the first option: I think it's useful to be able to run build-and-test.sh without having the JDK set up, or without having Python properly set up. Obviously that's more scope than what you have here, so perhaps let's leave it as: 1. Condition this new stuff on BUILD_JAVA. 2. Make a note at the BUILD_JAVA definition documenting this shortcoming. -- To view, visit http://gerrit.cloudera.org:8080/15409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525 Gerrit-Change-Number: 15409 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Mar 2020 22:31:48 +0000 Gerrit-HasComments: Yes
